Skip to content

Commit

Permalink
Cleanup scene unittest.
Browse files Browse the repository at this point in the history 
Signed-off-by: Martin Raspaud <martin.raspaud@smhi.se>
  • Loading branch information
@mraspaud
mraspaud committed Jun 24, 2015
1 parent 9f66308 commit 9a09e0f
Showing 1 changed file with 52 additions and 52 deletions.
104 changes: 52 additions & 52 deletions mpop/tests/test_scene.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def test_init_with_filenames(self):
def test_init_with_empty_filenames(self):
from mpop.scene import Scene
filenames = []
with mock.patch('mpop.scene.Scene._find_files_readers') as methmock:
with mock.patch('mpop.scene.Scene._find_files_readers'):
self.assertRaises(ValueError, Scene, filenames=filenames)

def test_init_with_sensor(self):
Expand Down Expand Up @@ -87,16 +87,16 @@ def test_get_filenames_with_start_time_and_end_time(self):
with mock.patch("mpop.scene.glob.iglob") as mock_iglob:
mock_iglob.return_value = ["file1", "file2", "file3", "file4", "file5"]
with mock.patch("trollsift.parser.Parser") as mock_parser:
mock_parser.return_value.parse.side_effect = [{"start_time": datetime(2015, 6, 23, 23, 57), #file1
"end_time": datetime(2015, 6, 23, 23, 59),},
{"start_time": datetime(2015, 6, 23, 23, 59),#file2
"end_time": datetime(2015, 6, 24, 0, 1),},
{"start_time": datetime(2015, 6, 24, 0, 1), #file3
"end_time": datetime(2015, 6, 24, 0, 3),},
{"start_time": datetime(2015, 6, 24, 0, 3), #file4
"end_time": datetime(2015, 6, 24, 0, 5),},
{"start_time": datetime(2015, 6, 24, 0, 5), #file5
"end_time": datetime(2015, 6, 24, 0, 7),},
mock_parser.return_value.parse.side_effect = [{"start_time": datetime(2015, 6, 23, 23, 57), # file1
"end_time": datetime(2015, 6, 23, 23, 59)},
{"start_time": datetime(2015, 6, 23, 23, 59), # file2
"end_time": datetime(2015, 6, 24, 0, 1)},
{"start_time": datetime(2015, 6, 24, 0, 1), # file3
"end_time": datetime(2015, 6, 24, 0, 3)},
{"start_time": datetime(2015, 6, 24, 0, 3), # file4
"end_time": datetime(2015, 6, 24, 0, 5)},
{"start_time": datetime(2015, 6, 24, 0, 5), # file5
"end_time": datetime(2015, 6, 24, 0, 7)},
]
self.assertEqual(scn.get_filenames(reader_info), ["file2", "file3", "file4", "file5"])

Expand All @@ -110,16 +110,16 @@ def test_get_filenames_with_start_time_and_npp_style_end_time(self):
with mock.patch("mpop.scene.glob.iglob") as mock_iglob:
mock_iglob.return_value = ["file1", "file2", "file3", "file4", "file5"]
with mock.patch("trollsift.parser.Parser") as mock_parser:
mock_parser.return_value.parse.side_effect = [{"start_time": datetime(2015, 6, 23, 23, 57), #file1
"end_time": datetime(1950, 1, 1, 23, 59),},
{"start_time": datetime(2015, 6, 23, 23, 59),#file2
"end_time": datetime(1950, 1, 1, 0, 1),},
{"start_time": datetime(2015, 6, 24, 0, 1), #file3
"end_time": datetime(1950, 1, 1, 0, 3),},
{"start_time": datetime(2015, 6, 24, 0, 3), #file4
"end_time": datetime(1950, 1, 1, 0, 5),},
{"start_time": datetime(2015, 6, 24, 0, 5), #file5
"end_time": datetime(1950, 1, 1, 0, 7),},
mock_parser.return_value.parse.side_effect = [{"start_time": datetime(2015, 6, 23, 23, 57), # file1
"end_time": datetime(1950, 1, 1, 23, 59)},
{"start_time": datetime(2015, 6, 23, 23, 59), # file2
"end_time": datetime(1950, 1, 1, 0, 1)},
{"start_time": datetime(2015, 6, 24, 0, 1), # file3
"end_time": datetime(1950, 1, 1, 0, 3)},
{"start_time": datetime(2015, 6, 24, 0, 3), # file4
"end_time": datetime(1950, 1, 1, 0, 5)},
{"start_time": datetime(2015, 6, 24, 0, 5), # file5
"end_time": datetime(1950, 1, 1, 0, 7)},
]
self.assertEqual(scn.get_filenames(reader_info), ["file2", "file3", "file4", "file5"])

Expand All @@ -133,11 +133,11 @@ def test_get_filenames_with_start_time(self):
with mock.patch("mpop.scene.glob.iglob") as mock_iglob:
mock_iglob.return_value = ["file1", "file2", "file3", "file4", "file5"]
with mock.patch("trollsift.parser.Parser") as mock_parser:
mock_parser.return_value.parse.side_effect = [{"start_time": datetime(2015, 6, 23, 23, 57)}, #file1
{"start_time": datetime(2015, 6, 23, 23, 59)},#file2
{"start_time": datetime(2015, 6, 24, 0, 1)}, #file3
{"start_time": datetime(2015, 6, 24, 0, 3)}, #file4
{"start_time": datetime(2015, 6, 24, 0, 5)}, #file5
mock_parser.return_value.parse.side_effect = [{"start_time": datetime(2015, 6, 23, 23, 57)}, # file1
{"start_time": datetime(2015, 6, 23, 23, 59)}, # file2
{"start_time": datetime(2015, 6, 24, 0, 1)}, # file3
{"start_time": datetime(2015, 6, 24, 0, 3)}, # file4
{"start_time": datetime(2015, 6, 24, 0, 5)}, # file5
]
self.assertEqual(scn.get_filenames(reader_info), ["file3", "file4", "file5"])

Expand All @@ -151,16 +151,16 @@ def test_get_filenames_with_start_time_provided(self):
with mock.patch("mpop.scene.glob.iglob") as mock_iglob:
mock_iglob.return_value = ["file1", "file2", "file3", "file4", "file5"]
with mock.patch("trollsift.parser.Parser") as mock_parser:
mock_parser.return_value.parse.side_effect = [{"start_time": datetime(2015, 6, 23, 23, 57), #file1
"end_time": datetime(2015, 6, 23, 23, 59),},
{"start_time": datetime(2015, 6, 23, 23, 59),#file2
"end_time": datetime(2015, 6, 24, 0, 1),},
{"start_time": datetime(2015, 6, 24, 0, 1), #file3
"end_time": datetime(2015, 6, 24, 0, 3),},
{"start_time": datetime(2015, 6, 24, 0, 3), #file4
"end_time": datetime(2015, 6, 24, 0, 5),},
{"start_time": datetime(2015, 6, 24, 0, 5), #file5
"end_time": datetime(2015, 6, 24, 0, 7),},
mock_parser.return_value.parse.side_effect = [{"start_time": datetime(2015, 6, 23, 23, 57), # file1
"end_time": datetime(2015, 6, 23, 23, 59)},
{"start_time": datetime(2015, 6, 23, 23, 59), # file2
"end_time": datetime(2015, 6, 24, 0, 1)},
{"start_time": datetime(2015, 6, 24, 0, 1), # file3
"end_time": datetime(2015, 6, 24, 0, 3)},
{"start_time": datetime(2015, 6, 24, 0, 3), # file4
"end_time": datetime(2015, 6, 24, 0, 5)},
{"start_time": datetime(2015, 6, 24, 0, 5), # file5
"end_time": datetime(2015, 6, 24, 0, 7)},
]
self.assertEqual(scn.get_filenames(reader_info), ["file2"])

Expand All @@ -173,11 +173,11 @@ def test_get_filenames_with_only_start_times_wrong(self):
with mock.patch("mpop.scene.glob.iglob") as mock_iglob:
mock_iglob.return_value = ["file1", "file2", "file3", "file4", "file5"]
with mock.patch("trollsift.parser.Parser") as mock_parser:
mock_parser.return_value.parse.side_effect = [{"start_time": datetime(2015, 6, 23, 23, 57)}, #file1
{"start_time": datetime(2015, 6, 23, 23, 59)},#file2
{"start_time": datetime(2015, 6, 24, 0, 1)}, #file3
{"start_time": datetime(2015, 6, 24, 0, 3)}, #file4
{"start_time": datetime(2015, 6, 24, 0, 5)}, #file5
mock_parser.return_value.parse.side_effect = [{"start_time": datetime(2015, 6, 23, 23, 57)}, # file1
{"start_time": datetime(2015, 6, 23, 23, 59)}, # file2
{"start_time": datetime(2015, 6, 24, 0, 1)}, # file3
{"start_time": datetime(2015, 6, 24, 0, 3)}, # file4
{"start_time": datetime(2015, 6, 24, 0, 5)}, # file5
]
self.assertEqual(scn.get_filenames(reader_info), [])

Expand All @@ -190,28 +190,28 @@ def test_get_filenames_with_only_start_times_right(self):
with mock.patch("mpop.scene.glob.iglob") as mock_iglob:
mock_iglob.return_value = ["file1", "file2", "file3", "file4", "file5"]
with mock.patch("trollsift.parser.Parser") as mock_parser:
mock_parser.return_value.parse.side_effect = [{"start_time": datetime(2015, 6, 23, 23, 57)}, #file1
{"start_time": datetime(2015, 6, 23, 23, 59)},#file2
{"start_time": datetime(2015, 6, 24, 0, 1)}, #file3
{"start_time": datetime(2015, 6, 24, 0, 3)}, #file4
{"start_time": datetime(2015, 6, 24, 0, 5)}, #file5
mock_parser.return_value.parse.side_effect = [{"start_time": datetime(2015, 6, 23, 23, 57)}, # file1
{"start_time": datetime(2015, 6, 23, 23, 59)}, # file2
{"start_time": datetime(2015, 6, 24, 0, 1)}, # file3
{"start_time": datetime(2015, 6, 24, 0, 3)}, # file4
{"start_time": datetime(2015, 6, 24, 0, 5)}, # file5
]
self.assertEqual(scn.get_filenames(reader_info), ["file3"])

def test_get_filenames_to_error(self):
from mpop.scene import Scene
from datetime import datetime
scn = Scene()
scn = Scene(start_time="bla")
reader_info = {"file_patterns": ["foo"],
"start_time": None}
with mock.patch("mpop.scene.glob.iglob") as mock_iglob:
mock_iglob.return_value = ["file1", "file2", "file3", "file4", "file5"]
with mock.patch("trollsift.parser.Parser") as mock_parser:
mock_parser.return_value.parse.side_effect = [{"start_time": datetime(2015, 6, 23, 23, 57)}, #file1
{"start_time": datetime(2015, 6, 23, 23, 59)},#file2
{"start_time": datetime(2015, 6, 24, 0, 1)}, #file3
{"start_time": datetime(2015, 6, 24, 0, 3)}, #file4
{"start_time": datetime(2015, 6, 24, 0, 5)}, #file5
mock_parser.return_value.parse.side_effect = [{"start_time": datetime(2015, 6, 23, 23, 57)}, # file1
{"start_time": datetime(2015, 6, 23, 23, 59)}, # file2
{"start_time": datetime(2015, 6, 24, 0, 1)}, # file3
{"start_time": datetime(2015, 6, 24, 0, 3)}, # file4
{"start_time": datetime(2015, 6, 24, 0, 5)}, # file5
]
self.assertRaises(ValueError, scn.get_filenames, reader_info)

Expand Down

0 comments on commit 9a09e0f

Please sign in to comment.