Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add restrict_to_localhost flag for the nameserver #22

Merged
merged 11 commits into from Mar 4, 2020

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Jul 3, 2019

This flag disables the listening to modules publishing on an another host (multicast only).

A test has been added.

Also some cleanup has been performed, and some sockets are now explicitly closed when they could have been left open (could help with the "too many open files" issue some of us have been having).

@mraspaud mraspaud requested a review from pnuu July 3, 2019 22:20
@mraspaud mraspaud self-assigned this Jul 3, 2019
@coveralls
Copy link

coveralls commented Mar 2, 2020

Coverage Status

Coverage increased (+0.5%) to 80.246% when pulling 3174405 on mraspaud:feature-restrict-to-localhost into 516725e on pytroll:master.

Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor suggestion on the command line option help and name.

bin/nameserver Outdated Show resolved Hide resolved
@mraspaud mraspaud merged commit 4b7e14a into pytroll:master Mar 4, 2020
@mraspaud mraspaud deleted the feature-restrict-to-localhost branch March 4, 2020 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants