Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instruct to create annotated tags #40

Merged
merged 1 commit into from Apr 25, 2022

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Apr 25, 2022

Simple addition to release instructions, where git tag -a needs to be used so that git push --follow-tags will work.

@pnuu pnuu requested a review from mraspaud April 25, 2022 09:51
@pnuu pnuu self-assigned this Apr 25, 2022
@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #40 (0d0fd69) into main (70a3a0d) will decrease coverage by 0.45%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   80.81%   80.36%   -0.46%     
==========================================
  Files          15       15              
  Lines        1991     1991              
==========================================
- Hits         1609     1600       -9     
- Misses        382      391       +9     
Impacted Files Coverage Δ
posttroll/version.py 41.57% <0.00%> (-3.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70a3a0d...0d0fd69. Read the comment docs.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pnuu pnuu merged commit 041d44f into pytroll:main Apr 25, 2022
@pnuu pnuu deleted the fix-release-instructions branch April 25, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants