Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix base writer to work with shapely 2.0+ #19

Merged
merged 8 commits into from Nov 9, 2018
Merged

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Nov 9, 2018

I think this might be a more flexible replacement for #18's problem. That is the temporary shapefile that was being made was only being used as a container...so let's not create the container and just make functions accept the lists/arrays directly.

@djhoese djhoese self-assigned this Nov 9, 2018
@howff
Copy link

howff commented Nov 9, 2018

Phew, that works for me, thank you!

@coveralls
Copy link

coveralls commented Nov 9, 2018

Coverage Status

Coverage increased (+24.5%) to 79.94% when pulling 0d825bc on bugfix-new-shapely into c9d5fe4 on master.

@djhoese djhoese merged commit 2bfad84 into master Nov 9, 2018
@djhoese djhoese deleted the bugfix-new-shapely branch November 9, 2018 21:42
@djhoese djhoese added the bug label Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants