Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to overlay user specific shapefiles from dict #62

Merged
merged 4 commits into from May 7, 2022

Conversation

lobsiger
Copy link
Contributor

This gives the possibility to add user specific shape files as overlays. These must be (lon/lat) and either shape-type polygon or line.
overlays[shapefiles] is a list of dicts that must at least look like {'filename' : '/full_path_to_your/special.shp'}. Polygons can be filled.
Christian Peters uses this for adding administrative boundaries of German 'States' (Bundesländer) on daily weather station images.
I also changed the order in overlays_from_dict(): 'grid' should not be added last as it will spoil the text labels of 'cities' and 'points'.

  • [x ] Tests added
  • [x ] Tests passed

@lobsiger
Copy link
Contributor Author

lobsiger commented Apr 29, 2022

@peters77 here is a HRV screen shot from Christian Peters:
HRV-GERMAN

@coveralls
Copy link

coveralls commented May 4, 2022

Coverage Status

Coverage increased (+0.2%) to 92.479% when pulling 95aee3a on lobsiger:usr_shps into 467f008 on pytroll:main.

@djhoese djhoese added this to In progress in PCW Spring 2022 via automation May 5, 2022
@djhoese
Copy link
Member

djhoese commented May 6, 2022

This branch now has conflicts with main. Could you try following my instructions in this comment: #60 (comment) and see if you can get pytroll's main branch merge into this usr_shps branch?

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

@djhoese djhoese changed the title Overlay user specific shapefiles from dict. Overlay user specific shapefiles from dict May 7, 2022
@djhoese djhoese changed the title Overlay user specific shapefiles from dict Add ability to overlay user specific shapefiles from dict May 7, 2022
@djhoese djhoese merged commit 632c2e7 into pytroll:main May 7, 2022
PCW Spring 2022 automation moved this from In progress to Done May 7, 2022
@lobsiger
Copy link
Contributor Author

lobsiger commented May 7, 2022

@djhoese thanks for merging this. I will now once again merge main into fix_cities (if necessry at all) and then comment my findings regarding test data files. It's already clear that you can delete all 120Mbytes of unused cities shape files in .../test_data/cities/ .

@lobsiger lobsiger deleted the usr_shps branch May 7, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants