Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix font loading when adding scale (colorbar) #14

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

peters77
Copy link
Contributor

@peters77 peters77 commented Apr 6, 2020

Add a check for font object in _add_scale as suggested by @djhoese

Now it should be possible to specify a font, fontsize and color for scale values/labels and colorbar title, e.g.:

'font': '/usr/share/fonts/truetype/dejavu/DejaVuSerif.ttf', 'font_size': 20,'line': 'white'

@coveralls
Copy link

coveralls commented Apr 6, 2020

Pull Request Test Coverage Report for Build 39

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.8%) to 44.965%

Files with Coverage Reduction New Missed Lines %
pydecorate/decorator_base.py 1 42.65%
Totals Coverage Status
Change from base Build 29: 0.8%
Covered Lines: 192
Relevant Lines: 427

💛 - Coveralls

@codecov
Copy link

codecov bot commented Apr 6, 2020

Codecov Report

Merging #14 into master will increase coverage by 0.83%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   44.00%   44.83%   +0.83%     
==========================================
  Files           4        4              
  Lines         425      426       +1     
==========================================
+ Hits          187      191       +4     
+ Misses        238      235       -3     
Impacted Files Coverage Δ
pydecorate/decorator_base.py 42.64% <100.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3127fcb...8d90339. Read the comment docs.

@djhoese djhoese changed the title add check for font object in add_scale Fix font loading when adding scale (colorbar) Apr 7, 2020
@djhoese djhoese added the bug label Apr 7, 2020
@djhoese djhoese self-assigned this Apr 7, 2020
@djhoese
Copy link
Member

djhoese commented Apr 7, 2020

Awesome! Thank you. Will make a new patch release since you were so quick to point this out.

@djhoese djhoese merged commit 4ed6e63 into pytroll:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants