Fix colorbar orientation to always be min->max #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First color left/bottom, last color right/top
|
Oh I also added pre-commit.ci to this repository. We were already using pre-commit-config in the project, but I forgot to enable the repository on pre-commit.ci. |
|
Ok I've updated the original description with example images. These are using the "rdbu" colormap so the first color is red, the last color is blue. |
Pull Request Test Coverage Report for Build 4055840102
💛 - Coveralls |
Pull Request Test Coverage Report for Build 4185617677
💛 - Coveralls |
mraspaud
approved these changes
Feb 15, 2023
|
As mentioned on slack, here is what this particular colormap looks like with the new HCL logic in trollimage:
About the same in my opinion, but maybe a little smoother/cleaner on the red to white transition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user of one of my projects noticed that the colors for vertical colorbars (scales) had the colors flipped from what they should be. As far as I can tell this has always been like this. Additionally, the colormap was always assumed to have increasing values, but in recent versions of trollimage it is possible to have values in reverse order (flipped values versus flipped colors). This produces colorbars that don't follow what I think most people would expect which is for the colorbar to go from the minimum value to the maximum value. In the horizontal orientation this means minimum value on the left, maximum on the right. For vertical orientation this means minimum value on the bottom, maximum on the top. This PR fixes all of this.