Stop using pkg_resources
#50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probably could remove the file as well
Pull Request Test Coverage Report for Build 5559304726
💛 - Coveralls |
djhoese
reviewed
Jul 15, 2023
| @@ -61,7 +60,7 @@ | |||
| # built documents. | |||
| # | |||
| # get version using setuptools-scm | |||
| release = get_distribution("pydecorate").version | |||
| release = get_version("pydecorate") | |||
There was a problem hiding this comment.
I'm tempted to say maybe this should just be import pydecorate; pydecorate.__version__, but eh let's see how using this goes. I've never used it here.
djhoese
reviewed
Jul 17, 2023
| font_path = resource_filename("pydecorate.fonts", "DejaVuSerif.ttf") | ||
| return aggdraw.Font("black", font_path, size=16) | ||
| font_path = HERE / "fonts" / "DejaVuSerif.ttf" | ||
| return aggdraw.Font("black", font_path.as_posix(), size=16) |
There was a problem hiding this comment.
Aggdraw needs a posix-y path for this? I've never used aggdraw on Windows so I wasn't sure.
There was a problem hiding this comment.
There was a problem hiding this comment.
Ok. I don't feel strongly enough to change it. It does, at a glance, make a reader of the code think that Windows paths are supported. Let's merge this! Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #49