Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calibration when 3b is totally deactivated #117

Merged
merged 3 commits into from Oct 27, 2022

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Oct 27, 2022

Fully deactivated 3b channel can crash the calibration. This PR fixes this.

This fixes #78 and fixes #22 in principle.

@mraspaud mraspaud added the bug label Oct 27, 2022
@mraspaud mraspaud self-assigned this Oct 27, 2022
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #117 (9f30e02) into main (28265cd) will increase coverage by 1.23%.
The diff coverage is 97.05%.

@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   73.94%   75.18%   +1.23%     
==========================================
  Files          30       30              
  Lines        2698     2732      +34     
==========================================
+ Hits         1995     2054      +59     
+ Misses        703      678      -25     
Impacted Files Coverage Δ
pygac/pod_reader.py 63.63% <50.00%> (-0.23%) ⬇️
pygac/klm_reader.py 68.11% <100.00%> (+8.71%) ⬆️
pygac/reader.py 81.77% <100.00%> (+2.21%) ⬆️
pygac/tests/test_klm.py 100.00% <100.00%> (+4.76%) ⬆️
pygac/tests/test_reader.py 98.35% <100.00%> (+0.01%) ⬆️
pygac/calibration.py 94.73% <0.00%> (+0.52%) ⬆️
pygac/lac_klm.py 82.35% <0.00%> (+17.64%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@sfinkens sfinkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And thanks for cleaning up the tests

@mraspaud mraspaud merged commit c8f3eca into pytroll:main Oct 27, 2022
@mraspaud mraspaud deleted the fix-3b-missing-calibration branch October 28, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle completely missing ICT or space counts Thermal calibration error
2 participants