-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in VIIRS geoloc definition #128
Conversation
Codecov Report
@@ Coverage Diff @@
## main #128 +/- ##
==========================================
+ Coverage 87.49% 87.51% +0.02%
==========================================
Files 15 15
Lines 2207 2211 +4
==========================================
+ Hits 1931 1935 +4
Misses 276 276
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I'm unfamiliar with this part of the code, but could someone tell me where/when this function is used? How was this not caught before? Thanks @frdcms for bringing this to our attention. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for spotting it!
Are there no tests for this currently, seems not?
I agree with @djhoese that this is a bit strange it has been sitting there for so long. I do not recall it. And I have mostly been working with the sounder instruments over the last years. And apparently we do not use this function in our real-time production, otherwise we should have seen it. So go ahead, please. |
2b55df6
to
4523748
Compare
Thanks @adybbroe |
4523748
to
aee96c9
Compare
Awesome! Thanks so much. This looks good to me. I'll merge this, but I'll let @adybbroe decide on when it would be a good time to do a release. It's been a long time since I've done one for pyorbital so it may be better for one of the other maintainers to do it. |
Hello @adybbroe, |
This should be included in the 1.8.0 release that is on PyPI. The package will get to conda-forge later today hopefully. |
Great! |
This PR fixes a typo in the code for VIIRS geoloc definition.