Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update celestrak urls #138

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Update celestrak urls #138

merged 1 commit into from
Jan 5, 2024

Conversation

dagnic
Copy link

@dagnic dagnic commented Dec 31, 2023

Celestrak starts to remove the legacy tle txt files. I've detected a 404 error on the active one and asked T.S. Kelso; he points me to this post on X. I now suggest to use the query links.

Copy link

codecov bot commented Dec 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (137e201) 87.50% compared to head (7d40562) 87.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #138   +/-   ##
=======================================
  Coverage   87.50%   87.51%           
=======================================
  Files          14       14           
  Lines        2209     2210    +1     
=======================================
+ Hits         1933     1934    +1     
  Misses        276      276           
Flag Coverage Δ
unittests 87.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Coverage Status

coverage: 87.562% (+0.006%) from 87.556%
when pulling 7d40562 on dagnic:main
into 137e201 on pytroll:main.

@djhoese
Copy link
Member

djhoese commented Jan 4, 2024

How urgent is this fix needed? I have almost zero experience with this package but I also don't remember when all of the people who do have experience are coming back from holiday time off.

@dagnic
Copy link
Author

dagnic commented Jan 4, 2024

I would say quite urgent because without the fix, it is not possible to get the satellite orbital parameters through the API. If you need time, one can either:

  • use my fix directly
  • manually downloaded the TLE file from celestrak website using the new link and just load the file with the API.

Copy link
Contributor

@adybbroe adybbroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Many thanks for this!

@djhoese djhoese merged commit 0428c8a into pytroll:main Jan 5, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants