Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bilinear resampling to areas with invalid coordinates #423

Merged
merged 2 commits into from
Mar 22, 2022

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Feb 16, 2022

The bilinear resampler didn't work for target areas that have invalid coordinates, like space pixels in the corners of full disk geostationary projections. This PR hopefully fixes this for data in xarray.DataArrays backed by dask arrays.

Tests are still needed.

@pnuu pnuu added the bug label Feb 16, 2022
@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #423 (3da3aa4) into main (1928289) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #423   +/-   ##
=======================================
  Coverage   93.89%   93.89%           
=======================================
  Files          65       65           
  Lines       11130    11164   +34     
=======================================
+ Hits        10450    10482   +32     
- Misses        680      682    +2     
Flag Coverage Δ
unittests 93.89% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyresample/bilinear/_base.py 95.74% <100.00%> (+0.04%) ⬆️
pyresample/bilinear/xarr.py 93.00% <100.00%> (+0.75%) ⬆️
pyresample/test/test_bilinear.py 100.00% <100.00%> (ø)
pyresample/ewa/dask_ewa.py 90.16% <0.00%> (-0.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1928289...3da3aa4. Read the comment docs.

@coveralls
Copy link

coveralls commented Feb 16, 2022

Coverage Status

Coverage increased (+0.001%) to 93.714% when pulling 3da3aa4 on pnuu:bugfix-bilinear-with-space-pixels into 1928289 on pytroll:main.

@pnuu pnuu self-assigned this Feb 16, 2022
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djhoese djhoese merged commit 0a031a3 into pytroll:main Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot resample with bilinear from lat/lon grid onto MSG full disk
3 participants