New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for duplicate coordinates in bbox_lonlats for geostationary area #475
Fix for duplicate coordinates in bbox_lonlats for geostationary area #475
Conversation
Codecov Report
@@ Coverage Diff @@
## main #475 +/- ##
==========================================
- Coverage 94.28% 94.24% -0.05%
==========================================
Files 69 73 +4
Lines 12394 12703 +309
==========================================
+ Hits 11686 11972 +286
- Misses 708 731 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense to the extent (pun intended) that I understand it. The solution seems simple enough. Thanks for fixing this. I'll merge it once tests pass and you can merge it into your boundary PR #473 and then we can merge that.
Some of the uncovered lines that coveralls is complaining about are a little concerning, but I assume you'll be working with this in the upcoming PRs so I'm not too worried. Most of the missed lines are the matplotlib plotting code which is annoying to test anyway. The one concerning one is the vertices to xyz helper function. The branch with the |
This PR removes the presence of duplicate consecutive coordinates in the geostationary are bbox/polygon.
This currently leads to the creation of SArcs that are actually points, and also leads to cross-product operations that lead to cartesian [0,0,0] and thus vector norm = 0 and thus division by 0 when normalizing.
Furthermore, it closes #474: when we retrieve 4 vertices we now get the 4 correct geos_area "extent" coordinates.
git diff origin/main **/*py | flake8 --diff