Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scale of AGRI response values #120

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Fix scale of AGRI response values #120

merged 1 commit into from
Oct 19, 2020

Conversation

simonrp84
Copy link
Member

@simonrp84 simonrp84 commented Oct 18, 2020 •
edited

Within pyspectral, the response functions for instruments are in the range 0->1.
However, the raw AGRI spectral responses are scaled between 0->100 and must be converted into the correct range during processing. This PR updates the AGRI RSR reader to perform this conversion.

  • Tests passed: Passes pytest pyspectral
  • Passes flake8 pyspectral

@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.48% when pulling dda2a32 on simonrp84:fix_agri_rsr into c1635c2 on pytroll:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.48% when pulling dda2a32 on simonrp84:fix_agri_rsr into c1635c2 on pytroll:master.

@adybbroe adybbroe self-assigned this Oct 19, 2020
@adybbroe adybbroe requested a review from pnuu October 19, 2020 07:11
@adybbroe adybbroe added the bug label Oct 19, 2020
@adybbroe adybbroe self-requested a review October 19, 2020 07:11
adybbroe
adybbroe approved these changes Oct 19, 2020
View reviewed changes
Copy link
Collaborator

@adybbroe adybbroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pnuu
pnuu approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adybbroe adybbroe merged commit abc0d52 into pytroll:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adybbroe adybbroe adybbroe approved these changes

@pnuu pnuu pnuu approved these changes

Assignees

@adybbroe adybbroe

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@simonrp84 @coveralls @adybbroe @pnuu