Add AGRI bands to the BANDNAMES dict #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leigh calculations.
Codecov Report
@@ Coverage Diff @@
## main #150 +/- ##
==========================================
+ Coverage 83.79% 88.00% +4.21%
==========================================
Files 23 22 -1
Lines 2394 2468 +74
==========================================
+ Hits 2006 2172 +166
+ Misses 388 296 -92
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…leigh calculations.
stickler-ci
reviewed
Jun 27, 2022
rsr_convert_scripts/agri_rsr.py
Outdated
| 'ch14': 1.0} | ||
|
|
||
| FY4_AGRI_BAND_NAMES = ['ch1', 'ch2', 'ch3', 'ch4', 'ch5', 'ch6', 'ch7', 'ch8', | ||
| 'ch9', 'ch10', 'ch11', 'ch12', 'ch13', 'ch14', 'ch15'] |
There was a problem hiding this comment.
E128 continuation line under-indented for visual indent
|
@simonrp84 what is the state of this PR? |
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
adybbroe
approved these changes
Sep 28, 2022
djhoese
approved these changes
Sep 28, 2022
|
Thanks for fixing this @adybbroe! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating a
true_colorimage in satpy I noticed that there's a lot of warnings that the band-specific RSRs cannot be found, which seems to be because in the RSRs the bands are listed asch1,ch2, etc whereas satpy usesC01,C02...This PR adds AGRI to the
BANDNAMESdict, enabling the RSRs to be used correctly.