Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPS-SG VII (METimage) channel names added #152

Merged
merged 2 commits into from
Sep 28, 2022

Conversation

pepephillips
Copy link
Contributor

@pepephillips pepephillips commented Jul 19, 2022

This PR adds the EPS-SG METimage (VII) channel naming convention (vii_xxx) to the bandnames.py file to enable pyspectral to be used with METimage .

  • Tests added none
  • Tests passed: Passes pytest test_rsr_reader.py
  • Passes flake8 pyspectral
  • Fully documented

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #152 (fb4a164) into main (6948a7a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #152   +/-   ##
=======================================
  Coverage   83.79%   83.79%           
=======================================
  Files          23       23           
  Lines        2394     2395    +1     
=======================================
+ Hits         2006     2007    +1     
  Misses        388      388           
Flag Coverage Δ
unittests 83.79% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyspectral/bandnames.py 100.00% <100.00%> (ø)

@adybbroe adybbroe merged commit 4224191 into pytroll:main Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants