Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NOAA-21 VIIRS #156

Merged
merged 3 commits into from
Oct 5, 2022
Merged

Conversation

adybbroe
Copy link
Collaborator

@adybbroe adybbroe commented Sep 27, 2022

This PR adds support for the JPSS-2 (NOAA-21) VIIRS RSR data.
The actual pyspectral formattet hdf5 files are not yet uploaded to zenodo, so the version pointing to the RSR files remains as before. The RSR file version will be updated in another PR. See #155 and #157

  • Closes #xxxx
  • Tests added
  • Tests passed: Passes pytest pyspectral
  • Passes flake8 pyspectral
  • Fully documented

Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
@adybbroe adybbroe self-assigned this Sep 27, 2022
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #156 (5601501) into main (f0abf64) will not change coverage.
The diff coverage is n/a.

❗ Current head 5601501 differs from pull request most recent head 1017b40. Consider uploading reports for the commit 1017b40 to get more accurate results

@@           Coverage Diff           @@
##             main     #156   +/-   ##
=======================================
  Coverage   88.03%   88.03%           
=======================================
  Files          22       22           
  Lines        2473     2473           
=======================================
  Hits         2177     2177           
  Misses        296      296           
Flag Coverage Δ
unittests 88.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@adybbroe adybbroe mentioned this pull request Sep 27, 2022
5 tasks
@adybbroe adybbroe requested review from djhoese and simonrp84 and removed request for pnuu October 5, 2022 14:06
@djhoese
Copy link
Member

djhoese commented Oct 5, 2022

Now that #157 is done, does the URL in this PR need to be updated? Or does a new upload to zenodo need to happen?

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really small cleanup comments, but otherwise looks good.

rsr_convert_scripts/viirs_rsr.py Outdated Show resolved Hide resolved
rsr_convert_scripts/viirs_rsr.py Outdated Show resolved Hide resolved
@adybbroe
Copy link
Collaborator Author

adybbroe commented Oct 5, 2022

Now that #157 is done, does the URL in this PR need to be updated? Or does a new upload to zenodo need to happen?

I have already uploaded a new version with NOAA-6 and JPSS-2 updates to Zenodo a few days ago. But you are absolutely right the URL ought to be updated. I merge main into this one.

Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
@adybbroe adybbroe merged commit fd07153 into pytroll:main Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants