-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for NOAA-21 VIIRS #156
Conversation
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Codecov Report
@@ Coverage Diff @@
## main #156 +/- ##
=======================================
Coverage 88.03% 88.03%
=======================================
Files 22 22
Lines 2473 2473
=======================================
Hits 2177 2177
Misses 296 296
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Now that #157 is done, does the URL in this PR need to be updated? Or does a new upload to zenodo need to happen? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really small cleanup comments, but otherwise looks good.
I have already uploaded a new version with NOAA-6 and JPSS-2 updates to Zenodo a few days ago. But you are absolutely right the URL ought to be updated. I merge main into this one. |
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
This PR adds support for the JPSS-2 (NOAA-21) VIIRS RSR data.
The actual pyspectral formattet hdf5 files are not yet uploaded to zenodo, so the version pointing to the RSR files remains as before. The RSR file version will be updated in another PR. See #155 and #157
pytest pyspectral
flake8 pyspectral