Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug getting bandname from RSR data #174

Merged
merged 2 commits into from Nov 22, 2022

Conversation

adybbroe
Copy link
Collaborator

@adybbroe adybbroe commented Nov 17, 2022

Fix a bug getting the correct band name from the RSR data object.

Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #174 (60b2332) into main (23f7457) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
+ Coverage   89.24%   89.29%   +0.05%     
==========================================
  Files          22       22              
  Lines        2519     2531      +12     
==========================================
+ Hits         2248     2260      +12     
  Misses        271      271              
Flag Coverage Δ
unittests 89.29% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyspectral/rsr_reader.py 78.10% <100.00%> (+0.33%) ⬆️
pyspectral/tests/test_rsr_reader.py 100.00% <100.00%> (ø)
pyspectral/utils.py 90.98% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@adybbroe adybbroe added bug PCW Pytroll Contributers Week labels Nov 17, 2022
…ntly supported (corresponding to the rsr files on Zenodo)

Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adybbroe adybbroe requested a review from pnuu November 18, 2022 11:21
@adybbroe adybbroe merged commit a0d3b98 into pytroll:main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug PCW Pytroll Contributers Week
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Bug plotting spectral responses with MODIS
3 participants