Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pkg_resources usage in config handling #207

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Nov 27, 2023

pkg_resources is deprecated. This removes the usage while also moving the access of the PSP_CONFIG_FILE environment variable from an import-time operation to a runtime operation inside the config function call.

  • Closes #xxxx
  • Tests added
  • Tests passed: Passes pytest pyspectral
  • Passes flake8 pyspectral
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@djhoese djhoese added enhancement dependencies Pull requests that update a dependency file labels Nov 27, 2023
@djhoese djhoese self-assigned this Nov 27, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6f3b523) 89.96% compared to head (77e3a31) 90.03%.

❗ Current head 77e3a31 differs from pull request most recent head 14f6ec1. Consider uploading reports for the commit 14f6ec1 to get more accurate results

Files Patch % Lines
pyspectral/config.py 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
+ Coverage   89.96%   90.03%   +0.07%     
==========================================
  Files          23       23              
  Lines        2580     2580              
==========================================
+ Hits         2321     2323       +2     
+ Misses        259      257       -2     
Flag Coverage Δ
unittests 90.03% <87.50%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@adybbroe adybbroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks for this!

@djhoese
Copy link
Member Author

djhoese commented Nov 27, 2023

I made one more small update, but github seems to be struggling showing this new commit. Will merge after it is recognized and passes tests.

@djhoese djhoese closed this Nov 27, 2023
@djhoese djhoese reopened this Nov 27, 2023
@djhoese djhoese merged commit 2e61927 into pytroll:main Nov 27, 2023
15 of 16 checks passed
@djhoese djhoese deleted the remove-pkg-resources branch November 27, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants