Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the solar spectrum code to use the included reference spectra #208

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Nov 27, 2023

Redo of #202 to get around permission issues. This also includes updated docs and tests to take advantage of the default argument added by @simonrp84.

  • Closes #xxxx
  • Tests added
  • Tests passed: Passes pytest pyspectral
  • Passes flake8 pyspectral
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@djhoese djhoese self-assigned this Nov 27, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fd32fe9) 89.27% compared to head (7830e7d) 90.00%.
Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
+ Coverage   89.27%   90.00%   +0.73%     
==========================================
  Files          23       23              
  Lines        2545     2571      +26     
==========================================
+ Hits         2272     2314      +42     
+ Misses        273      257      -16     
Flag Coverage Δ
unittests 90.00% <100.00%> (+0.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djhoese djhoese merged commit ed0209f into pytroll:main Nov 27, 2023
17 checks passed
@djhoese djhoese deleted the upd_solspec_filename branch November 27, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants