Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fengyun and geo-kompsat-2b sensor support #225

Merged
merged 4 commits into from May 7, 2024

Conversation

adybbroe
Copy link
Collaborator

@adybbroe adybbroe commented May 3, 2024

This PR basically just updates the link to zenodo to point to the latest RSR files with the recent addition of Chinese and Korean sensors

  • Closes #xxxx
  • Tests added
  • Tests passed: Passes pytest pyspectral
  • Passes flake8 pyspectral
  • Fully documented
  • Add your name to AUTHORS.md if not there already

Adam.Dybbroe added 3 commits May 3, 2024 16:35
…d korean sensors

Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
@adybbroe adybbroe requested a review from simonrp84 May 3, 2024 14:44
@adybbroe adybbroe self-assigned this May 3, 2024
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.00%. Comparing base (b1c040a) to head (5853de5).
Report is 25 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #225   +/-   ##
=======================================
  Coverage   90.00%   90.00%           
=======================================
  Files          23       23           
  Lines        2571     2571           
=======================================
  Hits         2314     2314           
  Misses        257      257           
Flag Coverage Δ
unittests 90.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yukaribbba
Copy link
Contributor

Please don't forget #192 :)

Copy link
Member

@simonrp84 simonrp84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending the inclusion of #192 this LGTM!

@adybbroe
Copy link
Collaborator Author

adybbroe commented May 7, 2024

I saw that I had actually included the rsr_ghi_FY-4B.h5 file downloaded from the link above on zenodo. So we should be ok!

@adybbroe adybbroe merged commit 219ead5 into pytroll:main May 7, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants