Adapt for later versions of TQDM #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ations to be an integer Signed-off-by: Adam Dybbroe <Adam.Dybbroe@smhi.se>
Signed-off-by: Adam Dybbroe <Adam.Dybbroe@smhi.se>
djhoese
reviewed
Dec 6, 2019
pyspectral/utils.py
Outdated
| @@ -433,7 +433,7 @@ def download_luts(**kwargs): | |||
| else: | |||
| aerosol_types = HTTPS_RAYLEIGH_LUTS.keys() | |||
|
|
|||
| chunk_size = 10124 | |||
| chunk_size = 4096 | |||
There was a problem hiding this comment.
According to https://requests.readthedocs.io/en/master/api/#requests.Response.iter_content the chunk size is number of bytes so this is only 4K. I think we want something in the range of 1-10MB.
There was a problem hiding this comment.
I just fixed that, you are too quick @djhoese ! :-)
There was a problem hiding this comment.
We are downloading files in the order of 3-75 MB
djhoese
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust ftp download chunk size and the number of expected iterations to an integer.
In the most recent version of tqdm (4.40 as opposed to 4.37) pyspectral fails if the total number of iterations when downloading data in chunks is not an integer.
tqdm is used to show status bar when downloading LUTs via ftp.
Thanks to @aronnem for reporting this!
pytest pyspectralflake8 pyspectral