Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix interpolation of symetrical tiepoints #19

Merged
merged 7 commits into from Feb 21, 2020
Merged

Fix interpolation of symetrical tiepoints #19

merged 7 commits into from Feb 21, 2020

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Dec 18, 2019 •
edited

There is a bug atm where symetrical tiepoints generate nans on the subsatellite track.
This is a workaround.

  • Tests added
  • Tests passed
  • Passes git diff origin/master **/*py | flake8 --diff

@mraspaud mraspaud added the bug label Dec 18, 2019
@mraspaud mraspaud self-assigned this Dec 18, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling 7668ed6 on mraspaud:fix-modis-interpolation into 7bef9da on pytroll:master.

@coveralls
Copy link

coveralls commented Dec 18, 2019 •
edited

Coverage Status

Coverage remained the same at ?% when pulling 14f12ea on mraspaud:fix-modis-interpolation into 2c27197 on pytroll:master.

@mraspaud mraspaud marked this pull request as ready for review December 18, 2019 08:59
adybbroe
adybbroe reviewed Feb 14, 2020
View reviewed changes
Copy link
Collaborator

@adybbroe adybbroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can't see anything odd here. But do you want to remove Python-2 support in the PR? Isn't it cleaner to do in a separate PR?

@mraspaud
Copy link
Member Author

Tests are failing with python 2, hence the removal

@mraspaud mraspaud merged commit 24552f0 into pytroll:master Feb 21, 2020
@mraspaud mraspaud deleted the fix-modis-interpolation branch February 21, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adybbroe adybbroe adybbroe left review comments

Assignees

@mraspaud mraspaud

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mraspaud @coveralls @adybbroe