Fix tests on i386 architectures #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraspaud
reviewed
Jun 13, 2023
There was a problem hiding this comment.
LGTM! 2e-9 is absolutely good enough I think... https://www.explainxkcd.com/wiki/index.php/2170:_Coordinate_Precision
mraspaud
approved these changes
Jun 13, 2023
Codecov Report
@@ Coverage Diff @@
## main #46 +/- ##
=======================================
Coverage 88.03% 88.03%
=======================================
Files 21 21
Lines 1438 1438
=======================================
Hits 1266 1266
Misses 172 172
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
The test failure seems to be unrelated |
|
Indeed. I'm rerunning the jobs, we'll see how it goes, otherwise maybe @djhoese has an idea? |
|
I think coveralls is having a hard time today. |
|
@mraspaud I restarted tests and things seem happier now. Had to restart the final coveralls upload twice. I also switched this to a "bug" label. Not sure I'd consider this an "enhancement" in any way. Merging now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On i386 platforms few unit tests fails.
This PR fixes those failures by setting an absolute tolerance value in floating point arrays comparison.
The absolute tolerance value used is
2e-9. Looking at the data values it seems a reasonable chaice but please feel free to make your own analysis.git diff origin/main **/*py | flake8 --diff