Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish correct start time for whole overpass #16

Merged
merged 5 commits into from
May 24, 2022

Conversation

gerritholl
Copy link
Collaborator

@gerritholl gerritholl commented Dec 29, 2021

When publishing an SDR, make sure we publish the start and end time for the entire overpass, not just for the final file.

When publishing a file, make sure we use the start and end time for the
entire overpass.

Fixes pytroll#3.
@gerritholl gerritholl mentioned this pull request Apr 29, 2022
For testing the correct start-end time, I had adapted the fake-files
fixture, which broke the test-spawn-cspp test.  Adapt the fake-input
file in the test-spawn-cspp test such that this test passes again.
@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #16 (382a916) into main (0201dc9) will increase coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   78.13%   78.34%   +0.20%     
==========================================
  Files          12       12              
  Lines         956      965       +9     
==========================================
+ Hits          747      756       +9     
  Misses        209      209              
Flag Coverage Δ
unittests 78.34% <100.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cspp_runner/runner.py 85.40% <100.00%> (+0.24%) ⬆️
cspp_runner/tests/test_runner.py 98.93% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0201dc9...382a916. Read the comment docs.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for taking the time to fix this annoying issue.

@mraspaud mraspaud added the bug label May 24, 2022
@mraspaud mraspaud merged commit 17b759e into pytroll:main May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The published message contains wrong start_time
2 participants