Switch hrit_msg_tutorial to use glob instead of find_files_and_readers #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the thread at pytroll/satpy#1517, this is a better example to avoid importing two timesteps onto a scene, and adds clarification about the warnings which are expected but would throw off a new user.
Fixed the quotation marks.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
djhoese
reviewed
Jan 29, 2021
|
I think I have implemented these proposed changes and have issued another |
|
There was a small typo, but I fixed it. Thanks for cleaning this notebook up. For future reference, you don't need to make a "new" pull request to update existing ones. You can just push your new commits to the same branch and GitHub will automatically update the existing pull request with your new commits. Thanks again. |
djhoese
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes suggested by thread: pytroll/satpy#1517 (comment)