Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pygrib openfiles #20

Merged
merged 9 commits into from
Dec 8, 2020
Merged

Conversation

adybbroe
Copy link
Contributor

@adybbroe adybbroe commented Dec 8, 2020

  • Closes #xxxx
  • Tests added
  • Tests passed: Passes pytest pyspectral
  • Passes flake8 pyspectral
  • Fully documented

Adam.Dybbroe added 6 commits October 21, 2020 12:25
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
@adybbroe adybbroe self-assigned this Dec 8, 2020
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this code needs some TLC, but this is good enough for now I guess.
Do we really need all these new debug messages?
Also, let's make a function for getting a temporary filename.

nwcsafpps_runner/prepare_nwp.py Outdated Show resolved Hide resolved
nwcsafpps_runner/prepare_nwp.py Outdated Show resolved Hide resolved
# Conflicts:
#	nwcsafpps_runner/pps_posttroll_hook.py
@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #20 (5ad39b9) into master (201454a) will decrease coverage by 0.07%.
The diff coverage is 9.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
- Coverage   27.87%   27.80%   -0.08%     
==========================================
  Files          11       11              
  Lines        1693     1705      +12     
==========================================
+ Hits          472      474       +2     
- Misses       1221     1231      +10     
Flag Coverage Δ
unittests 27.80% <9.52%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nwcsafpps_runner/prepare_nwp.py 0.00% <0.00%> (ø)
nwcsafpps_runner/utils.py 26.84% <100.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 201454a...5ad39b9. Read the comment docs.

Adam.Dybbroe added 2 commits December 8, 2020 11:42
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
@mraspaud
Copy link
Member

mraspaud commented Dec 8, 2020

LGTM, feel free to merge once the tests pass.

@adybbroe
Copy link
Contributor Author

adybbroe commented Dec 8, 2020

Thanks @mraspaud
I think it will fail on Ubuntu-latest. Something with gdal-config. I couldn't really see what I could do to make it pass, so I left it for now. Already a good step forward to have testing on github I thought.

@adybbroe
Copy link
Contributor Author

adybbroe commented Dec 8, 2020

Oh, it also fails on Windows, as I have hardcoded Linux style filepaths in the tests. The code had never run under Windows yet, as far as we know, so I will ignore this here, and address it in a separate PR

@adybbroe adybbroe merged commit f4e1f63 into pytroll:master Dec 8, 2020
@adybbroe adybbroe deleted the fix-pygrib-openfiles branch December 8, 2020 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants