-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pygrib openfiles #20
Conversation
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this code needs some TLC, but this is good enough for now I guess.
Do we really need all these new debug messages?
Also, let's make a function for getting a temporary filename.
# Conflicts: # nwcsafpps_runner/pps_posttroll_hook.py
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
==========================================
- Coverage 27.87% 27.80% -0.08%
==========================================
Files 11 11
Lines 1693 1705 +12
==========================================
+ Hits 472 474 +2
- Misses 1221 1231 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
LGTM, feel free to merge once the tests pass. |
Thanks @mraspaud |
Oh, it also fails on Windows, as I have hardcoded Linux style filepaths in the tests. The code had never run under Windows yet, as far as we know, so I will ignore this here, and address it in a separate PR |
pytest pyspectral
flake8 pyspectral