Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise time2wait in publish thread #24

Merged
merged 6 commits into from
Mar 17, 2021

Conversation

adybbroe
Copy link
Contributor

@adybbroe adybbroe commented Dec 17, 2020

  • Closes #xxxx
  • Tests added
  • Tests passed: Passes pytest
  • Passes flake8 pytroll-pps-runner
  • Fully documented

Adam.Dybbroe added 3 commits December 16, 2020 08:42
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
@adybbroe adybbroe self-assigned this Dec 17, 2020
@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #24 (4e3f4eb) into master (c734de3) will increase coverage by 0.10%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   29.71%   29.82%   +0.10%     
==========================================
  Files          11       12       +1     
  Lines        1740     1747       +7     
==========================================
+ Hits          517      521       +4     
- Misses       1223     1226       +3     
Flag Coverage Δ
unittests 29.82% <33.33%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nwcsafpps_runner/pps_posttroll_hook.py 79.14% <33.33%> (-0.49%) ⬇️
nwcsafpps_runner/__init__.py 66.66% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c734de3...4e3f4eb. Read the comment docs.

@adybbroe adybbroe marked this pull request as ready for review February 11, 2021 12:45
Adam.Dybbroe and others added 2 commits March 12, 2021 17:00
@adybbroe adybbroe requested a review from pnuu March 12, 2021 16:02
@adybbroe
Copy link
Contributor Author

Okay, I am merging this now, okay @mraspaud @pnuu and @TAlonglong ?

Copy link
Collaborator

@TAlonglong TAlonglong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TAlonglong TAlonglong merged commit 2526dd0 into pytroll:master Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants