RTD "Edit on Github" broken in "latest" documentation

[gerritholl]

Describe the bug

In the Readthedocs online documentation, when I click on "Edit on Github", I get an Error 404 ("This is not the web page you are looking for").

To Reproduce

1. Go to any page in the Readthedocs online documentation, for example, Adding a custom reader to Satpy. Make sure the version is set to "latest" (see dropdown menu in the bottom left).
2. In the top right, click on Edit on GitHub

Expected behavior

I would expect to be led to a page where I end up when I click "edit" on https://github.com/pytroll/satpy/blob/master/doc/source/dev_guide/custom_reader.rst, which links to https://github.com/pytroll/satpy/edit/master/doc/source/dev_guide/custom_reader.rst and allows me to edit the file in a textarea window within the GitHub website (it creates a branch in my fork and then a pull request from there).

Actual results

The link leads to https://github.com/pytroll/satpy/blob/origin/master/doc/source/dev_guide/custom_reader.rst, which shows a drawing of a strange figure standing on a beige surface with some oddly shaped buildings (also beige) in the background, with big numbers "404" and a text bubble with the figure saying "This is not the web page you are looking for". When I move my mouse cursor around, the character slightly moves relative to the drawn background.

Although the text bubble is accurate, I am not looking for this peculiar drawing, it is not a useful statement.

Screenshots

Environment Info:

• OS: Linux
• Satpy Version: Read The Docs "latest" version. When I switch to Read The Docs "stable" version, the edit link works.

[djhoese]

From what I can tell sphinx on RTD is adding an extra "origin" to the URL. It should be:

https://github.com/pytroll/satpy/blob/master/doc/source/dev_guide/custom_reader.rst

[gerritholl]

The working edit link from the "stable" RTD leads to https://github.com/pytroll/satpy/blob/a54decd8ee4f7aeb0c8d6aec33f48cd179ed2864/doc/source/dev_guide/custom_reader.rst

[gerritholl]

Actually, although the stable link works, it leads to an out of date commit.

[djhoese]

@gerritholl Can you double check this again? I think this is fixed now on RTD's side of things.

[gerritholl]

@djhoese This appears to work now.