Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEVIRI L1b netCDF reader not dask-compliant #1075

Closed
sjoro opened this issue Feb 13, 2020 · 1 comment · Fixed by #1109
Closed

SEVIRI L1b netCDF reader not dask-compliant #1075

sjoro opened this issue Feb 13, 2020 · 1 comment · Fixed by #1109
Assignees
Labels
enhancement code enhancements, features, improvements

Comments

@sjoro
Copy link
Collaborator

sjoro commented Feb 13, 2020

seviri_l1b_nc-reader is not using dask, i.e. get_dataset-method returns a plain xarray.Dataset-object.

The reader should be "daskified", which may have an impact on SEVIRICalibrationHandler in seviri_base.py and other readers that use this class.

@sjoro sjoro self-assigned this Feb 13, 2020
@sjoro sjoro added the enhancement code enhancements, features, improvements label Feb 13, 2020
@BENR0
Copy link
Collaborator

BENR0 commented Mar 10, 2020

Not directly related to dask but when working on the reader the following should probably be changed too. I noticed that the nc reader uses mask_and_scale=False while opening the dataset. These attribute (among others) are not removed from the dataset and therefore lead to what I think are unwanted results when writing out data with the cf writer. I think some of the attributes of the original file should be stripped (or updated) because they don't make sense later on, or are confusing (e.g. comment, long_name, nc_key, valid_min, valid_max, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants