Add missing_ok option to find_files_and_readers #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an optional keyword argument notfound_ok to satpy.readers.find_files_and_readers. It defaults to False (the current behaviour), but if set to True, getting zero results is no longer considered an error but will result in an empty dictionary instead.
djhoese
reviewed
Apr 27, 2020
There was a problem hiding this comment.
I wonder if missing_ok would be more inline with stdlib python: https://docs.python.org/3/library/pathlib.html#pathlib.Path.unlink
Although I thought this keyword argument was used more in the standard library, I can't find a lot of use for it. There is the exists_ok of mkdirs that I'm more familiar with.
Codecov Report
@@ Coverage Diff @@
## master #1165 +/- ##
=======================================
Coverage 89.60% 89.60%
=======================================
Files 200 200
Lines 29487 29488 +1
=======================================
+ Hits 26422 26423 +1
Misses 3065 3065
Continue to review full report at Codecov.
|
To be consistent with pathlib.Path.unlink, rename the ``notfound_ok`` keyword argument introduced in the previous commit by ``missing_ok``.
gerritholl
changed the title
mraspaud
added
component:scene
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional keyword argument
missing_oktosatpy.readers.find_files_and_readers. It defaults toFalse(the currentbehaviour), but if set to
True, getting zero results is no longerconsidered an error but will result in an empty dictionary instead.
flake8 satpyAUTHORS.mdif not there already