Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MODIS level 2 cloud products #1200

Closed
wants to merge 2 commits into from
Closed

Add support for MODIS level 2 cloud products #1200

wants to merge 2 commits into from

Conversation

simonrp84
Copy link
Member

This PR adds support for a subset of datasets contained in the MODIS level 2 cloud products (types MOD06 and MYD06). No code changes, just a new file pattern in the YAML and some new dataset names.

@coveralls
Copy link

coveralls commented May 12, 2020

Coverage Status

Coverage increased (+0.003%) to 89.624% when pulling 603fc1d on simonrp84:MxD06 into cf9aab4 on pytroll:master.

@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #1200 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1200   +/-   ##
=======================================
  Coverage   89.62%   89.62%           
=======================================
  Files         200      200           
  Lines       29550    29550           
=======================================
+ Hits        26483    26484    +1     
+ Misses       3067     3066    -1     
Impacted Files Coverage Δ
satpy/scene.py 90.22% <0.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf9aab4...603fc1d. Read the comment docs.

@mraspaud
Copy link
Member

Thanks for this PR! is there any overlap with #812 ?

@simonrp84
Copy link
Member Author

Thanks for this PR! is there any overlap with #812 ?

Aaah, I hadn't seen that PR. Yes, as far as I can see everything in my PR is also included in that PR. Do we have a timeline or anything still pending on #812 ? Would be great to have it integrated!

@mraspaud
Copy link
Member

I'm rereviewing it now

@mraspaud mraspaud added component:readers enhancement code enhancements, features, improvements labels Jun 1, 2020
@mraspaud mraspaud closed this in #812 Jun 1, 2020
@simonrp84 simonrp84 deleted the MxD06 branch June 2, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants