Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file pattern for NWCSAF input file names to 'grib' reader #1212

Merged
merged 2 commits into from May 20, 2020
Merged

Add file pattern for NWCSAF input file names to 'grib' reader #1212

merged 2 commits into from May 20, 2020

Conversation

gerritholl
Copy link
Collaborator

@gerritholl gerritholl commented May 20, 2020 •
edited

For the GRIB reader, add the file pattern corresponding to the NWCSAF
input file type, which ends in .grib. So far .grib2, .grb,
and .grb2 are recognised, but not .grib.

@gerritholl
GRIB: Add file pattern for NWCSAF input file names
f1a28be 
For the GRIB reader, add the file pattern corresponding to the NWCSAF
input file type, which ends in ``.grib``.  So far ``.grib2``, ``.grb``,
and ``.grb2`` are recognised, but not ``.grib``.
mraspaud
mraspaud requested changes May 20, 2020
View reviewed changes
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one typo

satpy/tests/reader_tests/test_grib.py Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented May 20, 2020 •
edited

Coverage Status

Coverage decreased (-0.001%) to 89.715% when pulling 9fac775 on gerritholl:grib-icon into b7d6f34 on pytroll:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 89.718% when pulling 9fac775 on gerritholl:grib-icon into b7d6f34 on pytroll:master.

@gerritholl gerritholl requested a review from mraspaud May 20, 2020 13:55
@djhoese djhoese self-assigned this May 20, 2020
@djhoese djhoese added component:readers enhancement code enhancements, features, improvements labels May 20, 2020
@djhoese djhoese merged commit 5bdc78e into pytroll:master May 20, 2020
@djhoese djhoese changed the title GRIB: Add file pattern for NWCSAF input file names Add file pattern for NWCSAF input file names to 'grib' reader May 20, 2020
@gerritholl gerritholl deleted the grib-icon branch May 20, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mraspaud mraspaud mraspaud approved these changes

@djhoese djhoese djhoese approved these changes

Assignees

@djhoese djhoese

Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gerritholl @coveralls @mraspaud @djhoese