Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update needed for vii_l1b_nc reader to match a change to the Test Data and processor #1842

Closed
ColinDuff opened this issue Oct 1, 2021 · 2 comments · Fixed by #1979
Closed
Assignees
Labels
component:readers enhancement code enhancements, features, improvements

Comments

@ColinDuff
Copy link
Contributor

The VII L1b test data and processor is being updated to fix one of the variable names in the calibration data

Currently the reader will use the following to access the data, in the init method

self._integrated_solar_irradiance = self['data/calibration_data/Band_averaged_solar_irradiance'].values

but this name will now change to band_averaged_solar_irradiance

Read in the calibration data correctly

The above line of code will fail due to the case change in the variable name

Environment Info:
Linux
V0.25 - but i checked the main branch and the erroneous code is still there

@ColinDuff
Copy link
Contributor Author

you can assign this issue to me, Colin Duff

@ColinDuff
Copy link
Contributor Author

The new version of the test data should be ready around the end of the year so I will coordinate this reader change to match the test data update

@mraspaud mraspaud added the enhancement code enhancements, features, improvements label Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants