You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Even though manual application of a modifier for example the SunZenithCorrector might be an unusual use case, the name and modifiers init kwargs should be set by default for modifiers (normally these get set during loading from the yaml configs) . This would make attributes more consistent.
Sounds good to me. I'm sure there will be annoying edge cases, but this seems like it would be going in the right direction. I also assume that modifiers[0] should be equal to the value of name right? That should maybe be checked in the __init__.
Feature Request
Even though manual application of a modifier for example the
SunZenithCorrector
might be an unusual use case, thename
andmodifiers
init kwargs should be set by default for modifiers (normally these get set during loading from the yaml configs) . This would make attributes more consistent.Currently this has to be set by the user like so:
Ideally the user can just initialize it like this (also because the above behaviour is not documented)
Describe any changes to existing user workflow
As far as I can see there are not changes.
The text was updated successfully, but these errors were encountered: