Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'to_xarray_dataset' method to Scene #367

Closed
djhoese opened this issue Jul 12, 2018 · 2 comments
Closed

Add 'to_xarray_dataset' method to Scene #367

djhoese opened this issue Jul 12, 2018 · 2 comments
Labels
Milestone

Comments

@djhoese
Copy link
Member

djhoese commented Jul 12, 2018

Is your feature request related to a problem? Please describe.
The Scene object was built and designed to replacing existing interfaces coming from satpy's predecessor mpop. However, now that we have switched to using xarray.DataArray objects as our main data containers we could and probably should switch to using xarray.Dataset objects (http://xarray.pydata.org/en/stable/generated/xarray.Dataset.html).

Describe the solution you'd like
Add a Scene.to_xarray_dataset or maybe Scene.to_dataset method that returns an xarray Dataset object from the loaded datasets.

Describe any changes to existing user workflow
Additional optional method right now that doesn't need to be used for anything. We could use this in the future to separate out the Scene -> writer interface so that writers are more xarray-specific (read: generic) and not Scene specific.

Additional python or other dependencies
None

Describe any changes required to the build process
None

Describe alternatives you've considered
It has been on my radar for a while that we could/should replace the Scene object with a Dataset object, but right now there is too much functionality inside the Scene object to do this smoothly.

@djhoese djhoese added enhancement code enhancements, features, improvements help wanted good first issue component:scene labels Jul 12, 2018
@djhoese djhoese added this to the v0.10 milestone Jul 12, 2018
@djhoese djhoese modified the milestones: v0.10, v1.0 Oct 9, 2018
@gerritholl
Copy link
Collaborator

This already exists...? Wis there some PR that should have closed this but didn't?

@djhoese
Copy link
Member Author

djhoese commented Mar 3, 2021

The referenced one above did it, #541.

@djhoese djhoese closed this as completed Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants