Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to skip tests if dependencies are missing #495

Closed
djhoese opened this issue Nov 9, 2018 · 1 comment
Closed

Update tests to skip tests if dependencies are missing #495

djhoese opened this issue Nov 9, 2018 · 1 comment
Assignees
Labels

Comments

@djhoese
Copy link
Member

djhoese commented Nov 9, 2018

Would it be a bad idea to make tests that don't have the necessary dependencies mark themselves as skipped? For example, the mitiff writer's (@TAlonglong) tests require the libtiff (pylibtiff) python library which isn't always the easiest to install. To have the tests fail may be too strong of a response, but I could see this being bad on CIs where we would want to be alerted in the most obvious way (failed tests) if dependencies are missing.

Thoughts?

@djhoese
Copy link
Member Author

djhoese commented Jun 1, 2021

No comments since making this. I'm closing this as we've generally decided that all tests should be runnable on CI and someone should expect failures for missing dependencies. Now that we have pytest it is much easier to do pytest satpy/tests/test_some_module.py.

@djhoese djhoese closed this as completed Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants