-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undocumented dependency packages #562
Comments
Thanks for pointing this out. The pydecorate dependency should probably be listed in the optional dependencies. Glymur I think is only used by that one reader which may not be working yet, but you are right it should be added to the optionals. The NinJo support is also iffy right now but maybe @loreclem could include it in future PRs where that is fixed. If you want to make a PR for this I wouldn't mind that. Otherwise I'll try to get to it later this week or during travel the week after. I should probably rename the optional dependencies to use the new reader names too. |
Thanks @djhoese. If you plan to rename readers then probably it is better you also address the dependency declaration directly. Just let me know if you plan to remove some of that dependences. |
@avalentino The reader names have been changed in the most recent 0.11 release, the optional dependency "extras" have not been updated to reflect all of these changes. How do you plan on handling all of these optional dependencies? Do you plan on only supporting a limited set of readers/writers in the default debian package? |
@djhoese the current status of the debian package can be found in [1].
All the above packages are already available in debian (or are in the queue to be uploaded in the main archive). At the moment i only plan to add:
that will be added to the list of recommended packages. Actually some of the less important packages that are currently in recommended could me moved to the "suggested" section which is a weaker kind of relation. [1] https://salsa.debian.org/debian-gis-team/satpy |
ah ... forgot to mention that also
are used somewhere but not declared in the serup .py. |
I think I personally think you should not include As for "glymur" I'm not familiar with the package, but if it is only used in one of the readers it isn't a big deal if it isn't included.
|
I'm looking through old issues and rediscovered this one. One is the current status of the debian satpy package? With my earlier question in this thread, I was really asking: what is your philosophy on Satpy's optional dependencies as they apply to the debian package? Satpy will have a lot of dependencies if you included them all. Are you going to include as many as are available in debian right now? Or are you going to limit the dependencies to those needed by the most popular readers and writers in Satpy? |
Dear @djhoese currently Debian in in freeze in preparation of the new stable release, Debian 11, that should be available in few weeks (months?). After the release of Debian 11 I will start to work on the packaging of latest version of satpy. Regarding the "philosophy" for dependency management I try to follow as close as possible what is specified in the upstream setup.py:
Sometimes I mark as "Suggested" (weaker relation) extra dependencies that are particularly large (or trigger a large number of indirect dependencies). |
Thanks for the info. I've created #1673 to cleanup some of this. |
There are three packages that are used by satpy but are not listed in the (optional) requirements list in setup.py:
In particular pydecorate seems to be used during unit testing.
To Reproduce
Expected behavior
All tests are executed without errors
Actual results
4 test failures
Environment Info:
Readers
=======
Environment variable PYGAC_CONFIG_FILE not set!
abi_l1b: ok
abi_l1b_scmi: ok
acspo: ok
ahi_hrit: ok
ahi_hsd: ok
amsr2_l1b: ok
avhrr_l1b_aapp: ok
avhrr_l1b_eps: ok
avhrr_l1b_gaclac: cannot find module 'satpy.readers.avhrr_l1b_gaclac' (No module named 'ConfigParser')
avhrr_l1b_hrpt: ok
caliop_l2_cloud: cannot find module 'satpy.readers.caliop_l2_cloud' (No module named 'pyhdf')
clavrx: cannot find module 'satpy.readers.clavrx' (No module named 'pyhdf')
electrol_hrit: ok
fci_l1c_fdhsi: ok
generic_image: ok
geocat: ok
ghrsst_l3c_sst: ok
goes-imager_hrit: ok
goes-imager_nc: ok
grib: ok
iasi_l2: ok
jami_hrit: ok
li_l2: ok
maia: ok
modis_l1b: cannot find module 'satpy.readers.modis_l1b' (No module named 'pyhdf')
msi_safe: cannot find module 'satpy.readers.msi_safe' (No module named 'glymur')
mtsat2-imager_hrit: ok
nucaps: ok
nwcsaf-geo: ok
nwcsaf-pps_nc: ok
olci_l1b: ok
olci_l2: ok
omps_edr: ok
sar-c_safe: ok
scatsat1_l2b: ok
seviri_l1b_hrit: ok
seviri_l1b_native: ok
seviri_l1b_nc: ok
slstr_l1b: ok
viirs_compact: ok
viirs_edr_flood: cannot find module 'satpy.readers.viirs_edr_flood' (No module named 'pyhdf')
viirs_l1b: ok
viirs_sdr: ok
Writers
cf: ok
geotiff: ok
mitiff: ok
ninjotiff: cannot find module 'satpy.writers.ninjotiff' (No module named 'pyninjotiff')
scmi: ok
simple_image: ok
The text was updated successfully, but these errors were encountered: