Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add x and y coordinates to all loaded gridded DataArrays #762

Closed
djhoese opened this issue May 11, 2019 · 1 comment
Closed

Add x and y coordinates to all loaded gridded DataArrays #762

djhoese opened this issue May 11, 2019 · 1 comment
Labels
component:readers component:resampling enhancement code enhancements, features, improvements PCW Pytroll Contributors' Week
Projects
Pytroll Contributor's Week - Spring 2...

Comments

@djhoese
Copy link
Member

djhoese commented May 11, 2019

Feature Request

Is your feature request related to a problem? Please describe.
Right now the "abi_l1b" reader creates DataArrays with the NetCDF's 'x' and 'y' coordinates which are radians and not super useful to most users.

Describe the solution you'd like
Any DataArrays that are loaded with a gridded AreaDefinition should have 'y' and 'x' coordinates forced to the AreaDefinitions coordinates. I'm not sure if this should overwrite it regardless or leave it if it exists.

Describe any changes to existing user workflow
No changes. Just new data available.

Additional context
We should probably adopt this and share the logic with what is already done in resampling.
@djhoese djhoese added enhancement code enhancements, features, improvements component:readers component:resampling PCW Pytroll Contributors' Week labels May 11, 2019
@djhoese
Copy link
Member Author

djhoese commented Sep 17, 2019

Closed by #788

@djhoese djhoese closed this as completed Sep 17, 2019
Pytroll Contributor's Week - Spring 2019 - Madison, WI automation moved this from To do to Done Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:readers component:resampling enhancement code enhancements, features, improvements PCW Pytroll Contributors' Week
Projects
Pytroll Contributor's Week - Spring 2...
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@djhoese