-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize builtin areas #819
Comments
In upcoming PRs in the frame of #1248 we'll add a few geostationary areas (as we also need them for SIFT). So it's a good occasion to start on this, as I think it's something needed (along with a gallery of areas as proposed in #1206 and a general cleanup as in #1207). We could start with sorting out the geostationary projection areas, and then divide them in "full-disk" and "local" areas. What do you think? |
I'd be ok with going forward with #1248 by adding various geostationary areas and grouping them together per-satellite. Maybe all of the "old" area/s and names should go at the end of the file and we'll just put some comments in there about them being deprecated and maybe try to add some code later on that actually prints out a warning about their deprecation? I think if we have a set of geostationary satellite areas and have "region" AreaDefinitions for example "Northern Europe", "Europe", etc (my first possible solution above) then we'll be doing really well. We should probably also find a way to auto-document these in the sphinx docs. Like something in the conf.py that loads the YAML and dynamically creates a restructuredtext list of the areas in the file. ...braindump complete. |
Sounds good! Although I guess it's hard to find out which areas are actually being used on a regular basis, and therefore should be kept (in their category) and not be relegated to the deprecated ones (with possible DeprecationWarning). |
Most likely it will be some of the newly named areas you create for #1248 that already exist with some name currently. At least those will be the first ones. The |
A possible place for triggering the deprecation warning could be in |
I thought we had an issue for this, but I can't find it.
Problem
We have a lot of areas provided in Satpy, but I'm not sure the usefulness of all of them for most users. They are also not sorted and there are none for the Americas right now (I think).
Possible Solutions
The text was updated successfully, but these errors were encountered: