Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap names for Vis/IR default natural_color and natural_color_sun composites #936

Closed
djhoese opened this issue Oct 11, 2019 · 2 comments
Closed
Labels
backwards-incompatibility Causes backwards incompatibility or introduces a deprecation component:compositors

Comments

@djhoese
Copy link
Member

djhoese commented Oct 11, 2019

The builtin composite for natural_color does not apply the sunz_corrected modifier to its inputs. To get those applied you have to ask for natural_color_sun. My current issue is that it has become fairly standard for natural_color in sensor-specific configs to be the sunz_corrected version.

As it is right now a sensor will see natural_color and natural_color_sun as two types of composites that could be generated, but they are actually the same thing.

Thoughts?

@djhoese djhoese added component:compositors backwards-incompatibility Causes backwards incompatibility or introduces a deprecation labels Oct 11, 2019
@pnuu
Copy link
Member

pnuu commented Oct 11, 2019

The SZA-cosine corrected version is the one we at FMI have in production. Also, we have them defined in local configs so I don't mind the change. As a disclaimer I should note that all the composites we use are locally defined, and we never use the built-in composites directly. And, frankly, I think no one should use them that way in operational context. Ever.

@djhoese
Copy link
Member Author

djhoese commented Jun 1, 2021

Looks like this was closed in #1066.

@djhoese djhoese closed this as completed Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-incompatibility Causes backwards incompatibility or introduces a deprecation component:compositors
Projects
None yet
Development

No branches or pull requests

2 participants