Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GEO boundary calculations to Pyresample #971

Open
pnuu opened this issue Nov 21, 2019 · 4 comments
Open

Move GEO boundary calculations to Pyresample #971

pnuu opened this issue Nov 21, 2019 · 4 comments

Comments

@pnuu
Copy link
Member

pnuu commented Nov 21, 2019

Feature Request

There is a multipurpose function satpy.readers.utils.get_geostationary_bounding_box() that should be in pyresample.boundary module.

Is your feature request related to a problem? Please describe.
I noticed this via pytroll/pyresample#228 when working on pytroll/trollflow2#67 . The other boundary calculations are located in Pyresample, so that would be a proper location for it.

Describe the solution you'd like
Move satpy.readers.utils.get_geostationary_bounding_box() and the associated helper functions to pyresample.boundary module.

Describe any changes to existing user workflow
The import of get_geostationary_bounding_box in trollflow2.plugins needs to be updated, along with the import added to satpy where the function is used.

@pnuu
Copy link
Member Author

pnuu commented Dec 3, 2019

There seems also to be an issue with this functionality with GOES-16/17, which define the area using ellps: GRS80. The functions used in the calculations expect to have a/b/h available in the proj_dict.

@pnuu pnuu self-assigned this Dec 3, 2019
@pnuu pnuu moved this from Planned to In progress in PCW Copenhagen 2019 Dec 3, 2019
@pnuu pnuu removed their assignment Dec 3, 2019
@pnuu
Copy link
Member Author

pnuu commented Dec 3, 2019

The functionality already seems to be in Pyresample! See: https://github.com/pytroll/pyresample/blob/master/pyresample/geometry.py#L1948

@pnuu
Copy link
Member Author

pnuu commented Dec 3, 2019

Oh, and the a/b/h issue I mentioned above is also fixed there: https://github.com/pytroll/pyresample/blob/master/pyresample/geometry.py#L1929

@djhoese
Copy link
Member

djhoese commented Dec 3, 2019

Yes, this was fixed in pyresample because newer versions of pyproj/PROJ will replace a/b combinations with the associated ellipsoid/datum if they can figure it out.

We'll need to update these to not use proj_dict and look at attributes in the CRS object in the future but that's a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PCW Copenhagen 2019
  
In progress
Development

No branches or pull requests

2 participants