Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overviews to output images #27

Merged
merged 10 commits into from Apr 1, 2019
Merged

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Mar 26, 2019

This PR adds a feature for embedding "overviews" to the saved TIFF images.

@pnuu pnuu added the enhancement New feature or request label Mar 26, 2019
@pnuu pnuu self-assigned this Mar 26, 2019
@pnuu pnuu requested a review from mraspaud March 26, 2019 11:29
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, but that should be done in satpy also. Could you create an issue for that there ?

"""Add overviews to images already written to disk."""
# Get the formats, including filenames and overview settings
product_list = job['product_list']['product_list']
for area in product_list:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use plist_iter ?

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works. We should remember to remove this once satpy supports it natively

@pnuu pnuu merged commit 5fc6c38 into pytroll:master Apr 1, 2019
@pnuu pnuu deleted the feature-overviews branch April 1, 2019 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants