Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XRImage.colorize to mask integer data with _FillValue #109

Merged
merged 3 commits into from
Oct 21, 2022

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Oct 20, 2022

  • Closes Active fire confidence geotiff images do not have transparent background ssec/polar2grid#545 (remove if there is no corresponding issue, which should only be the case for minor changes)
  • Tests added (for all bug fixes or enhancements)
  • Tests passed (for all non-documentation changes)
  • Passes git diff origin/master **/*py | flake8 --diff (remove if you did not edit any Python files)
  • Fully documented (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later)

@djhoese djhoese added the bug label Oct 20, 2022
@djhoese djhoese requested review from mraspaud and pnuu October 20, 2022 02:24
@djhoese djhoese self-assigned this Oct 20, 2022
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #109 (3641038) into main (a2ca805) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   92.89%   92.93%   +0.03%     
==========================================
  Files          11       10       -1     
  Lines        3478     3495      +17     
==========================================
+ Hits         3231     3248      +17     
  Misses        247      247              
Flag Coverage Δ
unittests 92.93% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
trollimage/tests/test_image.py 100.00% <100.00%> (ø)
trollimage/xrimage.py 89.23% <100.00%> (+0.10%) ⬆️
trollimage/__init__.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One debug print, otherwise LGTM.

trollimage/xrimage.py Outdated Show resolved Hide resolved
Co-authored-by: Panu Lahtinen <pnuu+git@iki.fi>
@mraspaud
Copy link
Member

Let me check if this works with the existing cloud top height composite...

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djhoese djhoese merged commit 9fbd03b into pytroll:main Oct 21, 2022
@djhoese djhoese deleted the bugfix-colorize-ints branch October 21, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants