Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readthedocs config file to force newer dependencies #110

Merged
merged 2 commits into from Nov 7, 2022

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Nov 3, 2022

It was pointed out on slack that there were some formatting issues in the installation instructions (the last pip install -e . wasn't showing up). It looks like readthedocs defaults to using really old versions for projects created before 2020.

  • Closes #xxxx (remove if there is no corresponding issue, which should only be the case for minor changes)
  • Tests added (for all bug fixes or enhancements)
  • Tests passed (for all non-documentation changes)
  • Passes git diff origin/master **/*py | flake8 --diff (remove if you did not edit any Python files)
  • Fully documented (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later)

@djhoese djhoese added the documentation Docstrings or Sphinx Documentation label Nov 3, 2022
@djhoese djhoese requested review from mraspaud and pnuu November 3, 2022 12:11
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #110 (bffedb4) into main (93e547a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #110   +/-   ##
=======================================
  Coverage   92.93%   92.93%           
=======================================
  Files          10       10           
  Lines        3495     3495           
=======================================
  Hits         3248     3248           
  Misses        247      247           
Flag Coverage Δ
unittests 92.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit c0a30db into pytroll:main Nov 7, 2022
@djhoese djhoese deleted the doc-config branch November 7, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Docstrings or Sphinx Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants