Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the brbg colormap #124

Merged
merged 4 commits into from Feb 20, 2023
Merged

Fix the brbg colormap #124

merged 4 commits into from Feb 20, 2023

Conversation

mraspaud
Copy link
Member

The BrBG colormap was wrong when compared to colorbrewer. This PR fixes it.

Reference:
https://colorbrewer2.org/#type=diverging&scheme=BrBG&n=11

@mraspaud mraspaud added the bug label Feb 16, 2023
@mraspaud mraspaud self-assigned this Feb 16, 2023
@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #124 (aab7c54) into main (02b8330) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   93.37%   93.37%           
=======================================
  Files          11       11           
  Lines        3624     3624           
=======================================
  Hits         3384     3384           
  Misses        240      240           
Flag Coverage Δ
unittests 93.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
trollimage/colormap.py 100.00% <ø> (ø)
trollimage/tests/test_image.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mraspaud mraspaud merged commit aa76b7b into pytroll:main Feb 20, 2023
@mraspaud mraspaud deleted the fix-brbg branch February 20, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants