-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dynamic colormap generation to docs #137
Conversation
Codecov Report
@@ Coverage Diff @@
## main #137 +/- ##
==========================================
+ Coverage 91.17% 91.18% +0.01%
==========================================
Files 11 11
Lines 3852 3847 -5
==========================================
- Hits 3512 3508 -4
+ Misses 340 339 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool idea, looks great so far!
Any last comments? Otherwise I'll merge this tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR adds a custom sphinx directory so that anywhere in the docs you can do
.. trollimage_colormap: trollimage.colormap.cmap_name
(or point to a list or dict of colormaps) and it will make a list of the images. This way the colormaps on the site are always correct with what the code products.I still have refactoring to do but the main idea is there.
git diff origin/master **/*py | flake8 --diff
(remove if you did not edit any Python files)