Preserve dtypes in XRImage "enhancements" #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
==========================================
+ Coverage 91.28% 91.47% +0.18%
==========================================
Files 11 11
Lines 3890 3952 +62
==========================================
+ Hits 3551 3615 +64
+ Misses 339 337 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
djhoese
reviewed
Nov 17, 2023
4 tasks
djhoese
reviewed
Nov 20, 2023
Co-authored-by: David Hoese <david.hoese@ssec.wisc.edu>
mraspaud
reviewed
Nov 21, 2023
trollimage/tests/test_image.py
Outdated
| @@ -1954,7 +1986,8 @@ def test_blend(self): | |||
| [0.768815, 0.72, 0.6728228, 0.62857145, 0.5885714], | |||
| [0.55412847, 0.5264665, 0.50666666, 0.495612, 0.49394494], | |||
| [0.5020408, 0.52, 0.5476586, 0.5846154, 0.63027024], | |||
| [0.683871, 0.7445614, 0.81142855, 0.8835443, 0.96]])) | |||
| [0.683871, 0.7445614, 0.81142855, 0.8835443, 0.96]], dtype=np.float32), | |||
There was a problem hiding this comment.
Ok, it looks like all the tests above this point were converted to float32, and the regular float version was just dropped. Maybe it's not necessary for all tests, but could dtype maybe be parameterized so the we don't just forget about floats here?
There was a problem hiding this comment.
I added the parametrize decorator to this and other tests to test with np.float32, np.float64 and float.
Co-authored-by: Martin Raspaud <martin.raspaud@smhi.se>
…/trollimage into preserve-enhancement-dtypes
mraspaud
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the "enhancments" in
XRImageclass currently upcasts float data to float64. This PR makes these (.gamma()and.colorize()to preserve the dtype of the input data. Checks are added also to other tests to check this holds true also for those operations.Note that #150 has the same done for
.crude_stretch().Includes also some test refactoring.
git diff origin/master **/*py | flake8 --diff(remove if you did not edit any Python files)