Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parse accepting strings with trailing characters #15

Merged
merged 4 commits into from Oct 9, 2019

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Sep 12, 2019

Pointed out by @sfinkens on slack. Parse should not allow trailing characters.

This fixes this by adding ^ and $ to the regular expression for extract_values and allowing it to be turned off with full_match=False to the parse function.

@djhoese djhoese added the bug label Sep 12, 2019
@djhoese djhoese self-assigned this Sep 12, 2019
@coveralls
Copy link

coveralls commented Sep 12, 2019

Coverage Status

Coverage increased (+0.1%) to 94.393% when pulling f7f2aa2 on djhoese:bugfix-full-match into d6c0b81 on pytroll:master.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making the full_match optional

Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djhoese djhoese merged commit ad03b59 into pytroll:master Oct 9, 2019
@djhoese djhoese deleted the bugfix-full-match branch October 9, 2019 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants