Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keys method to Parser class #46

Merged
merged 2 commits into from Nov 17, 2022
Merged

Conversation

carloshorn
Copy link
Contributor

This PR closes #45 by adding a keys method to the parser.Parser class.

trollsift/parser.py Outdated Show resolved Hide resolved
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Thanks.

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #46 (b04b6a2) into main (f28fbb5) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   95.98%   96.03%   +0.04%     
==========================================
  Files           7        7              
  Lines         598      605       +7     
==========================================
+ Hits          574      581       +7     
  Misses         24       24              
Flag Coverage Δ
unittests 96.03% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
trollsift/parser.py 94.00% <100.00%> (+0.05%) ⬆️
trollsift/tests/unittests/test_parser.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@djhoese djhoese merged commit 0570d16 into pytroll:main Nov 17, 2022
@djhoese djhoese self-assigned this Nov 17, 2022
@djhoese
Copy link
Member

djhoese commented Nov 21, 2022

This has been released as part of v0.5.0 (still waiting on conda-forge build).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide simple access to defined keys of a parser instance
2 participants